Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes search endpoint parameters #2818

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

Nisarg-Chokshi
Copy link
Contributor

Problem

Search API parameters were not getting updated correctly on changing the Filter (All/ Job/ Datasets) & Sort (Updated at/ Name) option

Solution

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've included a one-line summary of your change for the CHANGELOG.md (Depending on the change, this may not be necessary).
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Nisarg-Chokshi <[email protected]>
@boring-cyborg boring-cyborg bot added the web label May 18, 2024
Copy link

netlify bot commented May 18, 2024

Deploy Preview for peppy-sprite-186812 canceled.

Name Link
🔨 Latest commit b5bbb50
🔍 Latest deploy log https://app.netlify.com/sites/peppy-sprite-186812/deploys/6648791f0eccce00089c4080

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (9b1fdd1) to head (b5bbb50).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2818   +/-   ##
=========================================
  Coverage     84.57%   84.57%           
  Complexity     1441     1441           
=========================================
  Files           251      251           
  Lines          6503     6503           
  Branches        302      302           
=========================================
  Hits           5500     5500           
  Misses          850      850           
  Partials        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wslulciuc wslulciuc added this to the 0.48.0 milestone May 18, 2024
Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@phixMe phixMe merged commit 8e448ce into MarquezProject:main May 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants